Adapt storage UI #724
Merged
Adapt storage UI #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
adapt-storage-ui
branch
2 times, most recently
from
b44d277
to
def3880
Compare
- There is no need to invalidate the proposal. - The config phase is automaticall done if a product is selected.
joseivanlopez
force-pushed
the
adapt-storage-ui
branch
from
def3880
to
a61e419
Compare
jreidinger
approved these changes
Sep 4, 2023
- Probe will always start from scratch. - Clients are in charge of requesting a new proposal with the previous settings, if needed (e.g., if the system is deprecated).
- The client calculates the proposal again using the previous settings. - The backend never reuses the previous settings on probing.
joseivanlopez
force-pushed
the
adapt-storage-ui
branch
from
82baa4f
to
e2fb44e
Compare
jreidinger
approved these changes
Sep 5, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The org.opensuse.Agama.Storage1 service has changed its D-Bus API, but the UI was not adapted yet.
See #656.
Solution
Adapt the UI code to the new D-Bus API.
Note: some issues where detected and fixed in the backend code.
Testing