Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt storage UI #724

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Aug 29, 2023

Problem

The org.opensuse.Agama.Storage1 service has changed its D-Bus API, but the UI was not adapted yet.

See #656.

Solution

Adapt the UI code to the new D-Bus API.

Note: some issues where detected and fixed in the backend code.

Testing

  • Adapted unit tests.
  • Tested manually.

@joseivanlopez joseivanlopez force-pushed the adapt-storage-ui branch 2 times, most recently from b44d277 to def3880 Compare September 4, 2023 13:37
@joseivanlopez joseivanlopez marked this pull request as ready for review September 4, 2023 13:59
- Probe will always start from scratch.
- Clients are in charge of requesting a new proposal with the previous
  settings, if needed (e.g., if the system is deprecated).
- The client calculates the proposal again using the previous settings.
- The backend never reuses the previous settings on probing.
@joseivanlopez joseivanlopez merged commit d22fd0b into agama-project:storage-settings Sep 5, 2023
7 checks passed
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants